Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update abap-syntax version to 757, REGEX->PCRE #281

Merged
merged 11 commits into from
Sep 22, 2023
Merged

Update abap-syntax version to 757, REGEX->PCRE #281

merged 11 commits into from
Sep 22, 2023

Conversation

albertmink
Copy link
Contributor

@larshp
Copy link
Collaborator

larshp commented Sep 11, 2023

gonna run into runtime errors too,
image

@albertmink
Copy link
Contributor Author

Alright @larshp, I didn't expect this one, but hey it is a 'TODO' so it is not an error. Let's keep this PR open, as we don't need to rush

@albertmink albertmink mentioned this pull request Sep 11, 2023
Merged
@larshp
Copy link
Collaborator

larshp commented Sep 14, 2023

abaplint/abaplint#3102

@larshp
Copy link
Collaborator

larshp commented Sep 14, 2023

next = abaplint/transpiler#1322

larshp
larshp approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albertmink albertmink changed the title Update abap-syntax version to 757 Update abap-syntax version to 757, REGEX->PCRE Sep 22, 2023
@albertmink albertmink merged commit a4ab1c7 into main Sep 22, 2023
6 checks passed
@albertmink albertmink deleted the albertmink-patch-1 branch September 22, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp larshp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertmink @larshp