Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed requirements for language field #310

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

Markus1812
Copy link
Member

refers to #582

@Markus1812
Copy link
Member Author

Action JSON Schema / Diff generated schema fails, because the schema in the other repository is not yet updated. Will be fixed soon. Suggest merging after code review anyway.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Markus1812. Your changes look good to me. 👍

Action JSON Schema / Diff generated schema fails, because the schema in the other repository is not yet updated. Will be fixed soon. Suggest merging after code review anyway.

Hmm, I think we should try to update the abap-file-fromats repository nearly parallel. Otherwise, as far as I understand, our validation in the abap-file-formats repository will fail and confuse our contributors.

Therefore, I suggest, we prepare the change to update all schemas in the abap-file-formats repository. As soon as this is ready to merge, we merge this and the PR in asap-file-formts repository.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Markus1812. Welcome as contributor :)

@schneidermic0 schneidermic0 merged commit c0be9e4 into main Apr 10, 2024
6 of 7 checks passed
@schneidermic0 schneidermic0 deleted the Markus1812/language-tag branch April 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants