Removed maxLength and pattern for language field #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertmink
approved these changes
Apr 10, 2024
As soon as SAP/abap-file-formats-tools#310 is merged, I expect the checks to be green. Therefore, let's merge SAP/abap-file-formats-tools#310 and rerun the tests, first |
|
I think we have to ignore results of "Compatability Check / Is change compatible (pull_request)". To be honest, I don't understand why the check is complaining about the changes. Nothing has been added here. Do I miss anything? |
schneidermic0
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Looks good to me. Thanks, @Markus1812
Welcome as contributor also to this repository :)
|
Publishing is done one push to main. PR is not considered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #582
Generators updated with Pull Request SAP/abap-file-formats-tools#310
Documentation will be updated in separate Pull Request.