Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated documentation for the language field #611

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Conversation

Markus1812
Copy link
Member

Updates documentation according to changes made for #582 and adds a table for all supported languages and their BCP47 language code.

Follow up to #607

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good to me. 👍

Just one small comment/question (see below)

docs/languages.md Show resolved Hide resolved
@schneidermic0 schneidermic0 added the documentation Improvements or additions to documentation label Apr 11, 2024
schneidermic0 and others added 2 commits April 11, 2024 17:00
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed an aspect, in my review, yesterday:

docs/languages.md Outdated Show resolved Hide resolved
docs/languages.md Show resolved Hide resolved
Markus1812 and others added 4 commits April 12, 2024 08:16
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
@Markus1812
Copy link
Member Author

Just added a reference in json.md under the Original Language section.

json.md now has a reference to languages.md and languages.md contains a full table of all supported language codes.
languages.md also references to SAP Note 73606, to provide an official source for the table.

docs/json.md Outdated Show resolved Hide resolved
Markus1812 and others added 2 commits April 12, 2024 10:16
Co-authored-by: Albert Mink <albert.mink@sap.com>
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Markus1812

@Markus1812 Markus1812 merged commit c305541 into main Apr 12, 2024
9 checks passed
@Markus1812 Markus1812 deleted the language_documentation branch April 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants