-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated documentation for the language field #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good to me. 👍
Just one small comment/question (see below)
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed an aspect, in my review, yesterday:
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Just added a reference in json.md under the json.md now has a reference to languages.md and languages.md contains a full table of all supported language codes. |
Co-authored-by: Albert Mink <albert.mink@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Markus1812
Updates documentation according to changes made for #582 and adds a table for all supported languages and their BCP47 language code.
Follow up to #607