Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAIA] Add new object type SAIA #614

Merged
merged 16 commits into from
Oct 23, 2024
Merged

[SAIA] Add new object type SAIA #614

merged 16 commits into from
Oct 23, 2024

Conversation

uenal-akkaya
Copy link
Contributor

No description provided.

@albertmink albertmink added the new-object This is a new object type added to AFF label May 21, 2024
@albertmink albertmink self-requested a review May 21, 2024 18:31
@albertmink
Copy link
Contributor

Hi Uenal,

the ENUM can solved like the abap language version over here
https://github.com/SAP/abap-file-formats/blob/main/file-formats/zif_aff_types_v1.intf.abap#L42-L55

@albertmink
Copy link
Contributor

Hi @uenal-akkaya,

we recommend to put the object specific part (in ty_main) into a separate type. Example:
https://github.com/SAP/abap-file-formats/blob/main/file-formats/sito/type/zif_aff_sito_v2.intf.abap#L568-L581

wurzka
wurzka requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uenal-akkaya,
thanks for your changes. See my comments. They are mainly related to naming issues.

file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
wurzka
wurzka approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. Looks good to me.

@wurzka wurzka requested a review from a team June 14, 2024 12:55
@albertmink albertmink marked this pull request as draft July 11, 2024 11:33
@albertmink
Copy link
Contributor

Set to draft as there will be still changes in the AFF.
@uenal-akkaya feel free, once you have the next increment, to set status to Ready for review.

@schneidermic0 schneidermic0 marked this pull request as ready for review October 1, 2024 08:40
@Markus1812 Markus1812 mentioned this pull request Oct 1, 2024
Merged
@uenal-akkaya
Copy link
Contributor Author

@albertmink AFF updated, do I need to do something else?

albertmink
albertmink approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uenal-akkaya for finishing it off

@albertmink albertmink merged commit 873891a into SAP:main Oct 23, 2024
10 checks passed
@uenal-akkaya uenal-akkaya deleted the feature/saia branch October 23, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Markus1812 Markus1812 Markus1812 left review comments

@wurzka wurzka wurzka approved these changes

@albertmink albertmink albertmink approved these changes

Assignees
No one assigned
Labels
new-object This is a new object type added to AFF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uenal-akkaya @albertmink @Markus1812 @wurzka @schneidermic0