Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDCR] Add new object type for EDCR #630

Merged
merged 18 commits into from
Sep 27, 2024
Merged

Conversation

KUMARMUKULSAP
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jul 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@GuilhermeSaraiva96
Copy link

Hi,

Maybe the Pull Request is not yet review-ready, but the AFF contains no information, except for the type name. Is this on purpose?

@albertmink albertmink added the new-object This is a new object type added to AFF label Jul 15, 2024
@GuilhermeSaraiva96 GuilhermeSaraiva96 self-requested a review July 22, 2024 13:06
Copy link

@GuilhermeSaraiva96 GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that my last question is clarified

@KUMARMUKULSAP
Copy link
Contributor Author

There are no additional attributes to this object, we only need description of the object

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your AFF type. Please delete the .DS_Store file and add an example with the name z_aff_example_edcr.edcr.json, even though its nearly empty. Remember to link it in the README.md.

file-formats/edcr/type/zif_aff_edcr_v1.intf.abap Outdated Show resolved Hide resolved
@KUMARMUKULSAP
Copy link
Contributor Author

KUMARMUKULSAP commented Aug 28, 2024

Thank you for your AFF type. Please delete the .DS_Store file and add an example with the name z_aff_example_edcr.edcr.json, even though its nearly empty. Remember to link it in the README.md.

@Markus1812 : I have done these fixes, but i am getting error in checks for examples and README files as "Wrong line endings or no final newline". Can you suggest how can I fix these issues?

@Markus1812
Copy link
Member

Thank you for adapting our suggestions. We have fixed all line endings of the example and README file and added a new line at the end of file.

All checks except Contributor License Agreement are now fulfilled. If you could please check the first comment and perform the necessary actions.

@KUMARMUKULSAP
Copy link
Contributor Author

@Markus1812 : I have signed the CLA agreement.

@Markus1812 Markus1812 removed the request for review from GuilhermeSaraiva96 August 29, 2024 12:04
@Markus1812 Markus1812 requested a review from a team August 29, 2024 12:04
Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. In the next step, the ux-review team will take over.

@Markus1812 Markus1812 added the ux-review ready AFF is ready for UX review label Aug 29, 2024
@wurzka wurzka removed the request for review from a team September 10, 2024 09:34
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wurzka wurzka merged commit c8dfd4a into SAP:main Sep 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF ux-review ready AFF is ready for UX review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants