-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDCR] Add new object type for EDCR #630
Conversation
|
Hi, Maybe the Pull Request is not yet review-ready, but the AFF contains no information, except for the type name. Is this on purpose? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes so that my last question is clarified
There are no additional attributes to this object, we only need description of the object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your AFF type. Please delete the .DS_Store file and add an example with the name z_aff_example_edcr.edcr.json
, even though its nearly empty. Remember to link it in the README.md.
@Markus1812 : I have done these fixes, but i am getting error in checks for examples and README files as "Wrong line endings or no final newline". Can you suggest how can I fix these issues? |
Thank you for adapting our suggestions. We have fixed all line endings of the example and README file and added a new line at the end of file. All checks except Contributor License Agreement are now fulfilled. If you could please check the first comment and perform the necessary actions. |
@Markus1812 : I have signed the CLA agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. In the next step, the ux-review team will take over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
No description provided.