Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAJC]: Add value help to parameters #649

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Conversation

heichmann
Copy link
Contributor

No description provided.

@Markus1812 Markus1812 requested a review from a team August 14, 2024 08:35
@Markus1812 Markus1812 added the ux-review ready AFF is ready for UX review label Aug 14, 2024
Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating your AFF. We will follow up with a ux-review performed by our colleagues.

@wurzka wurzka removed the ux-review ready AFF is ready for UX review label Sep 10, 2024
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wurzka
Copy link
Contributor

wurzka commented Sep 10, 2024

As adding non mandatory fields is compatible, there is no requirement for updating the format version. Therefore, we can merge the changes.

@wurzka wurzka merged commit 7b8bf6b into SAP:main Sep 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants