Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIFR] - Adding field aifRecipient to AFF for AIFR #673

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

D047539
Copy link
Contributor

@D047539 D047539 commented Nov 15, 2024

Short explanation of the background:
During our tests, we discovered the need for an additional field in the AIFR, specifically the AIF Recipient.
It must be possible to assign the same AIF recipient to different namespaces.

The object name is derived from the namespace and the AIF Recipient. To ensure accurate derivation, we include both fields in the creation wizard and set the object name as read-only.
Since the exact derivation from object name Recipient back to Namespace and AIF Recipient may not always be possible, we displayed both fields as read-only in the editor for informational purposes.

@schneidermic0
Copy link
Contributor

Technically, adding new mandatory fields is considered as an incompatible change.

However, since AIFR is still in development, I think we can still accept incompatible changes. This means, we need to ignore the failing compatibility check in this PR.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the addition looks good to me. I have just added a comment wrt "AIF" prefix. Maybe, others have an opinion on this.

Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We performed UX check on this change. Looks good to me.

@schneidermic0 schneidermic0 merged commit 42bed29 into SAP:main Dec 3, 2024
9 of 10 checks passed
@schneidermic0
Copy link
Contributor

We have skipped the compatibility check. See my comment above

However, since AIFR is still in development, I think we can still accept incompatible changes. This means, we need to ignore the failing compatibility check in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants