From 42fa2b1ac4e09e075aedba4ebf2202293bf0bcf3 Mon Sep 17 00:00:00 2001 From: Pany Date: Tue, 3 Dec 2024 07:24:54 +0100 Subject: [PATCH 1/7] EVTO added --- file-formats/evto/README.md | 5 + file-formats/evto/evto-v1.json | 94 +++++++++++++++++++ .../evto/examples/z_aff_example.evto.json | 11 +++ .../evto/type/zif_aff_evto_v1.intf.abap | 40 ++++++++ .../evto/type/zif_aff_evto_v1.intf.json | 7 ++ 5 files changed, 157 insertions(+) create mode 100644 file-formats/evto/README.md create mode 100644 file-formats/evto/evto-v1.json create mode 100644 file-formats/evto/examples/z_aff_example.evto.json create mode 100644 file-formats/evto/type/zif_aff_evto_v1.intf.abap create mode 100644 file-formats/evto/type/zif_aff_evto_v1.intf.json diff --git a/file-formats/evto/README.md b/file-formats/evto/README.md new file mode 100644 index 000000000..d440085eb --- /dev/null +++ b/file-formats/evto/README.md @@ -0,0 +1,5 @@ +# EVTO File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.evto.json` | 1 | [`zif_aff_evto_v1.intf.abap`](./type/zif_aff_evto_v1.intf.abap) | [`evto-v1.json`](./evto-v1.json) | [`z_aff_example.evto.json`](./examples/z_aff_example.evto.json) diff --git a/file-formats/evto/evto-v1.json b/file-formats/evto/evto-v1.json new file mode 100644 index 000000000..98532336d --- /dev/null +++ b/file-formats/evto/evto-v1.json @@ -0,0 +1,94 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/evto/evto-v1.json", + "title": "Event Object", + "description": "SAP object type", + "type": "object", + "properties": { + "formatVersion": { + "title": "ABAP File Format Version", + "description": "The ABAP file format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2 + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "majorVersion": { + "title": "Major Version", + "description": "Major version", + "type": "integer", + "minimum": 1, + "maximum": 2147483647 + }, + "minorVersion": { + "title": "Minor Version", + "description": "Minor version", + "type": "integer", + "minimum": 0, + "maximum": 2147483647 + }, + "patchVersion": { + "title": "Patch Version", + "description": "Patch version", + "type": "integer", + "minimum": 0, + "maximum": 2147483647 + }, + "sapObjectType": { + "title": "SAP Object Type", + "description": "SAP Object Type", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "majorVersion", + "minorVersion", + "patchVersion", + "sapObjectType" + ] +} \ No newline at end of file diff --git a/file-formats/evto/examples/z_aff_example.evto.json b/file-formats/evto/examples/z_aff_example.evto.json new file mode 100644 index 000000000..9857c4cc6 --- /dev/null +++ b/file-formats/evto/examples/z_aff_example.evto.json @@ -0,0 +1,11 @@ +{ + "formatVersion": "1", + "header": { + "description": "Example Event Object.", + "originalLanguage": "en" + }, + "majorVersion": 1, + "minorVersion": 0, + "patchVersion": 4, + "sapObjectType": "Z_AFF_EXAMPLE" +} diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap new file mode 100644 index 000000000..ee0fbba03 --- /dev/null +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -0,0 +1,40 @@ +INTERFACE if_aff_evto_v1 + PUBLIC. + + TYPES: + "!

Event Object

+ "! SAP object type + BEGIN OF ty_main, + "! $required + format_version TYPE if_aff_types_v1=>ty_format_version, + + "!

Header

+ "! Header + "! $required + header TYPE if_aff_types_v1=>ty_header_60_cloud, + + "!

Major Version

+ "! Major version + "! $minimum 1 + "! $required + major_version TYPE i, + + "!

Minor Version

+ "! Minor version + "! $minimum 0 + "! $required + minor_version TYPE i, + + "!

Patch Version

+ "! Patch version + "! $minimum 0 + "! $required + patch_version TYPE i, + + "!

SAP Object Type

+ "! SAP Object Type + "! $required + sap_object_type TYPE c LENGTH 30, + + END OF ty_main. +ENDINTERFACE. \ No newline at end of file diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.json b/file-formats/evto/type/zif_aff_evto_v1.intf.json new file mode 100644 index 000000000..f59855318 --- /dev/null +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "RAP EEE: Event Object AFF Type Interface", + "originalLanguage": "en" + } +} From d72cd3267a99518e8e7524eff8e445fb1c55ff12 Mon Sep 17 00:00:00 2001 From: Pany Date: Tue, 3 Dec 2024 07:28:17 +0100 Subject: [PATCH 2/7] Line endings --- file-formats/evto/evto-v1.json | 2 +- file-formats/evto/type/zif_aff_evto_v1.intf.abap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/evto/evto-v1.json b/file-formats/evto/evto-v1.json index 98532336d..ce431d62d 100644 --- a/file-formats/evto/evto-v1.json +++ b/file-formats/evto/evto-v1.json @@ -91,4 +91,4 @@ "patchVersion", "sapObjectType" ] -} \ No newline at end of file +} diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap index ee0fbba03..14307fc8b 100644 --- a/file-formats/evto/type/zif_aff_evto_v1.intf.abap +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -37,4 +37,4 @@ INTERFACE if_aff_evto_v1 sap_object_type TYPE c LENGTH 30, END OF ty_main. -ENDINTERFACE. \ No newline at end of file +ENDINTERFACE. From e2f6980db620039b2b9b952be5a0584ebeae355a Mon Sep 17 00:00:00 2001 From: Pany Date: Tue, 3 Dec 2024 07:35:32 +0100 Subject: [PATCH 3/7] Description in schema corrected --- file-formats/evto/evto-v1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/evto/evto-v1.json b/file-formats/evto/evto-v1.json index ce431d62d..b34b46c45 100644 --- a/file-formats/evto/evto-v1.json +++ b/file-formats/evto/evto-v1.json @@ -3,7 +3,7 @@ "$schema": "https://json-schema.org/draft/2020-12/schema", "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/evto/evto-v1.json", "title": "Event Object", - "description": "SAP object type", + "description": "Event Object", "type": "object", "properties": { "formatVersion": { From 37acbdf60cd24b1e7b86be53dc4ef9ceb688abca Mon Sep 17 00:00:00 2001 From: Andre Pany Date: Tue, 3 Dec 2024 07:39:24 +0100 Subject: [PATCH 4/7] ABAP Linter corrections --- file-formats/evto/type/zif_aff_evto_v1.intf.abap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap index 14307fc8b..d1457819d 100644 --- a/file-formats/evto/type/zif_aff_evto_v1.intf.abap +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -1,4 +1,4 @@ -INTERFACE if_aff_evto_v1 +INTERFACE zif_aff_evto_v1 PUBLIC. TYPES: @@ -6,12 +6,12 @@ INTERFACE if_aff_evto_v1 "! SAP object type BEGIN OF ty_main, "! $required - format_version TYPE if_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE if_aff_types_v1=>ty_header_60_cloud, + header TYPE zif_aff_types_v1=>ty_header_60_cloud, "!

Major Version

"! Major version From 4b982721a6f9c916a7bf7228c58dbd20f37be0cc Mon Sep 17 00:00:00 2001 From: Andre Pany Date: Tue, 3 Dec 2024 07:42:35 +0100 Subject: [PATCH 5/7] Description in interface corrected --- file-formats/evto/type/zif_aff_evto_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap index d1457819d..4093316c9 100644 --- a/file-formats/evto/type/zif_aff_evto_v1.intf.abap +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -3,7 +3,7 @@ INTERFACE zif_aff_evto_v1 TYPES: "!

Event Object

- "! SAP object type + "! Event Object BEGIN OF ty_main, "! $required format_version TYPE zif_aff_types_v1=>ty_format_version, From 71a26a6a7926a69a0939e48a8a7574fdd489c3d5 Mon Sep 17 00:00:00 2001 From: Andre Pany Date: Wed, 4 Dec 2024 07:43:57 +0100 Subject: [PATCH 6/7] Incorporate review changes --- file-formats/evto/evto-v1.json | 71 +++++++++++-------- .../evto/examples/z_aff_example.evto.json | 10 +-- .../evto/type/zif_aff_evto_v1.intf.abap | 32 +++++---- 3 files changed, 67 insertions(+), 46 deletions(-) diff --git a/file-formats/evto/evto-v1.json b/file-formats/evto/evto-v1.json index b34b46c45..1a3b04fac 100644 --- a/file-formats/evto/evto-v1.json +++ b/file-formats/evto/evto-v1.json @@ -54,41 +54,52 @@ "originalLanguage" ] }, - "majorVersion": { - "title": "Major Version", - "description": "Major version", - "type": "integer", - "minimum": 1, - "maximum": 2147483647 - }, - "minorVersion": { - "title": "Minor Version", - "description": "Minor version", - "type": "integer", - "minimum": 0, - "maximum": 2147483647 - }, - "patchVersion": { - "title": "Patch Version", - "description": "Patch version", - "type": "integer", - "minimum": 0, - "maximum": 2147483647 - }, - "sapObjectType": { - "title": "SAP Object Type", - "description": "SAP Object Type", - "type": "string", - "maxLength": 30 + "generalInformation": { + "title": "General Information", + "description": "General information", + "type": "object", + "properties": { + "sapObjectType": { + "title": "SAP Object Type", + "description": "SAP Object Type", + "type": "string", + "maxLength": 30 + }, + "majorVersion": { + "title": "Major Version", + "description": "Major version", + "type": "integer", + "minimum": 1, + "maximum": 2147483647 + }, + "minorVersion": { + "title": "Minor Version", + "description": "Minor version", + "type": "integer", + "minimum": 0, + "maximum": 2147483647 + }, + "patchVersion": { + "title": "Patch Version", + "description": "Patch version", + "type": "integer", + "minimum": 0, + "maximum": 2147483647 + } + }, + "additionalProperties": false, + "required": [ + "sapObjectType", + "majorVersion", + "minorVersion", + "patchVersion" + ] } }, "additionalProperties": false, "required": [ "formatVersion", "header", - "majorVersion", - "minorVersion", - "patchVersion", - "sapObjectType" + "generalInformation" ] } diff --git a/file-formats/evto/examples/z_aff_example.evto.json b/file-formats/evto/examples/z_aff_example.evto.json index 9857c4cc6..d5d5673e1 100644 --- a/file-formats/evto/examples/z_aff_example.evto.json +++ b/file-formats/evto/examples/z_aff_example.evto.json @@ -4,8 +4,10 @@ "description": "Example Event Object.", "originalLanguage": "en" }, - "majorVersion": 1, - "minorVersion": 0, - "patchVersion": 4, - "sapObjectType": "Z_AFF_EXAMPLE" + "generalInformation": { + "sapObjectType": "Z_AFF_EXAMPLE", + "majorVersion": 1, + "minorVersion": 0, + "patchVersion": 4 + } } diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap index 4093316c9..fea0eb011 100644 --- a/file-formats/evto/type/zif_aff_evto_v1.intf.abap +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -2,16 +2,13 @@ INTERFACE zif_aff_evto_v1 PUBLIC. TYPES: - "!

Event Object

- "! Event Object - BEGIN OF ty_main, - "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, - - "!

Header

- "! Header + "!

General Information

+ "! General information + BEGIN OF ty_general_information, + "!

SAP Object Type

+ "! SAP Object Type "! $required - header TYPE zif_aff_types_v1=>ty_header_60_cloud, + sap_object_type TYPE c LENGTH 30, "!

Major Version

"! Major version @@ -30,11 +27,22 @@ INTERFACE zif_aff_evto_v1 "! $minimum 0 "! $required patch_version TYPE i, + END OF ty_general_information. - "!

SAP Object Type

- "! SAP Object Type + TYPES: + "!

Event Object

+ "! Event Object + BEGIN OF ty_main, "! $required - sap_object_type TYPE c LENGTH 30, + format_version TYPE zif_aff_types_v1=>ty_format_version, + + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60_cloud, + "!

General Information

+ "! General information + general_information TYPE ty_general_information, END OF ty_main. ENDINTERFACE. From 217fb32dd7fb20f5cc04c73c943d2fc127a7dc77 Mon Sep 17 00:00:00 2001 From: Andre Pany Date: Wed, 4 Dec 2024 07:55:19 +0100 Subject: [PATCH 7/7] Update interface --- file-formats/evto/type/zif_aff_evto_v1.intf.abap | 1 + 1 file changed, 1 insertion(+) diff --git a/file-formats/evto/type/zif_aff_evto_v1.intf.abap b/file-formats/evto/type/zif_aff_evto_v1.intf.abap index fea0eb011..06c7b5b83 100644 --- a/file-formats/evto/type/zif_aff_evto_v1.intf.abap +++ b/file-formats/evto/type/zif_aff_evto_v1.intf.abap @@ -43,6 +43,7 @@ INTERFACE zif_aff_evto_v1 "!

General Information

"! General information + "! $required general_information TYPE ty_general_information, END OF ty_main. ENDINTERFACE.