Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain Flattening results are currently underperforming #62

Open
maawoo opened this issue Sep 1, 2022 · 5 comments
Open

Terrain Flattening results are currently underperforming #62

maawoo opened this issue Sep 1, 2022 · 5 comments
Labels
SNAP Upstream SNAP issues that we likely can't fix ourselves.

Comments

@maawoo
Copy link
Member

maawoo commented Sep 1, 2022

https://forum.step.esa.int/t/inferior-terrain-flattening-results-when-using-external-dem/37221

@maawoo maawoo added the SNAP Upstream SNAP issues that we likely can't fix ourselves. label Sep 1, 2022
@johntruckenbrodt
Copy link
Member

Thanks for the great summary in this STEP issue. It was increasingly hard to follow the discussions around this topic. Let's hope they soon come up with a fix.

@maawoo maawoo assigned maawoo and unassigned maawoo Jan 3, 2023
@johntruckenbrodt
Copy link
Member

Things are moving forward:

https://forum.step.esa.int/t/terrain-flattening-results-in-garbage-when-using-copernicus-30m-auto-download/33777/34

The reason that the TF result obtained using auto downloaded Copernicus 30m DEM is different from that obtained using external Copernicus 30m DEM file is that the DEM oversampling factor is computed differently. The oversampling factor is computed using the DEM resolution and the image pixel spacing. In the former case, the DEM resolution is given while in the latter case the DEM resolution is computed using Earth model. We have updated the oversampling factor calculation so that it is the same for both cases. The fix will be available in the next release.

@maawoo
Copy link
Member Author

maawoo commented Jan 27, 2023

Finally! 🎉 Thanks for the update!

@johntruckenbrodt
Copy link
Member

#78 should bring some improvement. To be revised once the new version is out.

@johntruckenbrodt
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SNAP Upstream SNAP issues that we likely can't fix ourselves.
Projects
None yet
Development

No branches or pull requests

2 participants