Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SimEnergyDeposit filter module for systematics studies (v09_89_01_01, release/SBN2024A #491

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

jzettle
Copy link
Contributor

@jzettle jzettle commented Dec 9, 2024

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
Enabling filtering of SimEnergyDeposits around z=0 to capture the effect of not directly simulating a structure that holds the two sections of the ICARUS ind1 plane together at z=0. Does not affect the nominal simulation and this is geared towards ICARUS systematic variation studies. Identical code changes towards the develop branch were reviewed and approved in #486 and this code was developed using the release tag v09_89_01_01 in the first place. Testing this version gives the expected filtering behavior on a set of a few events. This correctly includes only the 4 commits that are directly part of this request and the previous approval process.

@jzettle jzettle added the enhancement New feature or request label Dec 9, 2024
@ibsafa ibsafa self-requested a review December 11, 2024 21:09
@ibsafa ibsafa merged commit 295a7a7 into release/SBN2024A Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants