Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactoring to the SBND fhicl workflow #374

Open
11 tasks
fjnicolas opened this issue Jul 13, 2023 · 4 comments · May be fixed by #507
Open
11 tasks

Major refactoring to the SBND fhicl workflow #374

fjnicolas opened this issue Jul 13, 2023 · 4 comments · May be fixed by #507
Assignees
Labels
help wanted Extra attention is needed maintenance

Comments

@fjnicolas
Copy link
Contributor

fjnicolas commented Jul 13, 2023

From conversation with @henrylay97: our current "standard" fhicl workflow has become messy and would need a major refactoring in the near future. This issue is just to remind ourselves to work on that after the about to start workshop production and before the next mayor production.

A non complete list of things to do:

  • Turn SCE on as default (Make default fcls use SCE config #287)
  • What data products do we want/need to keep after G4?
    • It may be different for the different workflows we currently have available (legacy gen+g4, rockbox, recently added scrubs, recently added Wire Cell...)
    • We'd probably need to differenciate what's needed for production level vs user level
    • Revisit what's drop by the lite fhicls
  • Standarize a workflow for WC?
  • Better organize the fhicl directories foe each stage
    • E.g. standard/g4 currently has more than 100 fhicls. It makes complicated to easily find the relevant/essential fhicls. Maybe add more subdirectories for each specific set of fhicls (eg recomb_variations, timelife_variations, etc)
  • Invert dependencies in genie+cosmics gen fhicl (Invert dependencies of genie+cosmics fcl files #201)
  • Update wiki page
  • [to be continued]

To be discussed in AI meetings.

@henrylay97
Copy link
Member

One thing I have already thought to add to this when we do this is try and move things that are high level reco that currently reside in cafmaker into reco2 (things like PID tools, CRUMBS, MCS etc).

@henrylay97
Copy link
Member

https://github.com/SBNSoftware/sbndcode/blob/develop/sbndcode/JobConfigurations/standard/gen/overlay/prodoverlay_corsika_cosmics_proton_dirtpropagation_sbnd.fcl

Just dumping things in this issue as I find them... Can we add gibuu to the name of this fcl?

@VCLanNguyen VCLanNguyen self-assigned this Jul 26, 2023
@absolution1
Copy link
Contributor

Just to say, I have slowly started on some reorganisation: https://github.com/SBNSoftware/sbndcode/tree/dbrailsf_noicefclmate/sbndcode

It's being slowly discussed in the sbnd-software slack

@absolution1
Copy link
Contributor

absolution1 commented Apr 19, 2024

The first PR: #460 is up
This focuses on reco1

@bear-is-asleep bear-is-asleep linked a pull request Aug 30, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants