Change voxelization scheme for hybrid model #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the voxelization scheme used by the optical library (hybrid mode). The voxel boundaries in the previous library didn’t match the active volume edges (mismatch ~4 cm). This can lead to an overestimation in the number of detected photons produced by
pdfastsimout.A new library using a redefined voxelization scheme has been generated by @ggamezdiego. The wrong visibilities reported in issue #243 were fixed by hand (taking advantage of the detector symmetry along the drift direction). A comparison of the visibility map at X~-208 cm and its symmetric configuration for the corrected library can be seen in the following figure:
NB: the new optical library can be found in ‘/sbnd/app/users/gamez/SBND/New-LibHybrid/SBND_OpLibOUT_v2.00New.root’. The library in ‘sbnd_data/OpticalLibrary’ needs to be replaced with the new version.