Light sim+reco updates for SBN2022A release #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l argon (hybrid model)
…del_propagation_times' into feature/pgreen_2022A_light_sim_reco
With the SemiAnalyticalModel class, the OpT0Finder code will work with the new LArG4
|
@marcodeltutto @fjnicolas could you check all the required changes from your parts are present? |
marcodeltutto
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the light simulation and reconstruction updates for the SBN2022A release, cherry-picking the required commits to allow compatibility with the SBN2021C branch. Commits taken from:
Requires SBNSoftware/sbncode#230 and LArSoft/larsim#84.