Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to use UIImage/NSImage as defaults when init the AnimatedImage with JPEG data #277

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

dreampiggy
Copy link
Collaborator

This match the behavior when passing with the JPEG url initializer

This close SDWebImage/SDWebImage#3625

@dreampiggy dreampiggy added the animated image AnimatedImage struct label Oct 21, 2023
… with JPEG data

This match the behavior when passing with the JPEG url initializer
@dreampiggy dreampiggy force-pushed the bugfix/jpeg_animatedimage_data branch from 07fcee4 to 5009333 Compare October 21, 2023 08:25
@dreampiggy
Copy link
Collaborator Author

@hstdt Does this fix your issue ? We can release a new beta version.

Or if you want the 2.x (This 3.x changes the API of WebImage/AnimatedImage to match Apple's AsyncImage). We can backport this commits and release another 2.x version

@dreampiggy dreampiggy merged commit 5c6bfdf into master Oct 21, 2023
3 of 4 checks passed
@dreampiggy dreampiggy deleted the bugfix/jpeg_animatedimage_data branch October 21, 2023 10:27
@dreampiggy
Copy link
Collaborator Author

dreampiggy commented Oct 21, 2023

@hstdt Released both v2.2.4 version as well as the 3.0.0-beta.2 (Which drop iOS 13 and use AsyncImage like API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animated image AnimatedImage struct
Projects
None yet
1 participant