Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AnimatedImage API to expose the SDAnimatedImageView #285

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Nov 28, 2023

This is not necessary to hide the details and use UIView super view

Changes

  • Change AnimatedImage.onViewCreate(:)/onViewUpdate(:)/onViewDestroy(:) -> AnimatedImage closure arg from UIView into SDAnimatedImageView

@dreampiggy dreampiggy force-pushed the feature/export_animated_image_view_type branch from 92de407 to 2f78daf Compare November 28, 2023 17:27
@dreampiggy dreampiggy force-pushed the feature/export_animated_image_view_type branch 2 times, most recently from a7dd378 to f859139 Compare November 29, 2023 08:04
@dreampiggy dreampiggy added the API API changes label Nov 29, 2023
@dreampiggy dreampiggy force-pushed the feature/export_animated_image_view_type branch from 92164bd to db8e2b6 Compare November 29, 2023 11:03
@dreampiggy dreampiggy force-pushed the feature/export_animated_image_view_type branch 3 times, most recently from 47e07bf to ffaaa05 Compare December 1, 2023 08:30
@dreampiggy dreampiggy force-pushed the feature/export_animated_image_view_type branch from ffaaa05 to 25ffe1e Compare December 1, 2023 08:33
@dreampiggy dreampiggy merged commit 4012a65 into master Dec 1, 2023
4 checks passed
@dreampiggy dreampiggy deleted the feature/export_animated_image_view_type branch December 1, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant