Groups implemented

[ReinhardDP]

Groups in now implemented in the models and I added some fields.
I am not sure if the migrations work.

[PJDeSmijter]

looks good, submission.group_id should indeed be not nullable but this works for now

[RunoBoy]

Group_id was nullable so that a submission could be part of a student OR of a group, so one of the fields needed to be null. But in this version indeed, it can't be NULL. Migrating when removing the NULL constraction gives some problems considering the row now has missing values. But considering that we are working with an empty database we could use the trick of removing the auto-generated files in migrations (except __init__.py) and than re-running
python manage.py makemigrations
python manage.py migrate
should give us the final model implementation

[PJDeSmijter]

I get this error when executing migrate/makemigrations:

`System check identified some issues:

WARNINGS:
users.Student.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
users.Teacher.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0002_alter_submissions_file, 0002_alter_submissions_file_alter_submissions_output_test in submissions).
To fix them run 'python manage.py makemigrations --merge'`

[robinpdev]

I get this error when executing migrate/makemigrations:

`System check identified some issues:

WARNINGS: users.Student.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField. HINT: ForeignKey(unique=True) is usually better served by a OneToOneField. users.Teacher.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField. HINT: ForeignKey(unique=True) is usually better served by a OneToOneField. CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0002_alter_submissions_file, 0002_alter_submissions_file_alter_submissions_output_test in submissions). To fix them run 'python manage.py makemigrations --merge'`

what happens when you run python manage.py makemigrations --merge
Of course, run this inside the backend docker container by doing docker exec -it pigeonhole-backend sh first

[PJDeSmijter]

I get this error when executing migrate/makemigrations:
System check identified some issues: WARNINGS: users.Student.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField. HINT: ForeignKey(unique=True) is usually better served by a OneToOneField. users.Teacher.id: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField. HINT: ForeignKey(unique=True) is usually better served by a OneToOneField. CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0002_alter_submissions_file, 0002_alter_submissions_file_alter_submissions_output_test in submissions). To fix them run 'python manage.py makemigrations --merge'

what happens when you run python manage.py makemigrations --merge Of course, run this inside the backend docker container by doing docker exec -it pigeonhole-backend sh first

It made some new migration files, looks like it works.

[RunoBoy]

should be finished