Homescreen testen #220
Merged
Homescreen testen #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyniersbram
approved these changes
May 18, 2024
| @@ -4,7 +4,7 @@ | |||
| <h3>{{ subject.name }}</h3> | |||
| <v-skeleton-loader v-if="isInstructorsLoading" type="text" /> | |||
| <p v-else-if="instructors!.length > 0" class="teacher"> | |||
| {{ instructors![0].given_name }} | |||
| {{ instructors![0].given_name + " " + instructors![0].surname }} | |||
There was a problem hiding this comment.
Is het een idee om deze eerst te sorteren op is_teacher, dan is de kans groter dat de naam van de effectieve prof hier te zien zal zijn, en niet die van een assistent.
There was a problem hiding this comment.
klopt, ik heb dit aan issue #229 toegevoegd
# Conflicts: # frontend/src/i18n/locales/en.ts # frontend/src/i18n/locales/nl.ts
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testen voor views: