Skip to content

Commit

Permalink
chore: translations, test linting
Browse files Browse the repository at this point in the history
  • Loading branch information
EwoutV committed Apr 4, 2024
1 parent 68461a0 commit 314eaba
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 14 deletions.
4 changes: 4 additions & 0 deletions frontend/src/assets/lang/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
"description": "Beschrijving",
"year": "Academiejaar",
"search": {
"search": "Zoeken",
"faculty": "Faculteit",
"year": "Academiejaar",
"placeholder": "Zoek een vak op naam",
"title": "Zoek een vak",
"results": "{0} vakken gevonden voor ingestelde filters"
}
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/test/unit/course_service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ const {
getCourses,
getCoursesByStudent,

createCourse,
cloneCourse,
deleteCourse,
} = useCourses();

// "describe" bundles tests about 1 specific thing; here we're testing course
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/test/unit/project_service.test.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
import { describe, it, expect, beforeEach } from 'vitest';
import { describe, it, expect } from 'vitest';
import { useProject } from '@/composables/services/project.service.ts';

const {
projects,
project,
getProjectByID,
getProjectsByCourse,
getProjectsByCourseAndDeadline,
getProjectsByStudent,

createProject,
deleteProject,
} = useProject();

describe('project', (): void => {
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/test/unit/structure_check.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
import { describe, it, expect, beforeEach } from 'vitest';
import { describe, it, expect } from 'vitest';
import { useStructureCheck } from '@/composables/services/structure_check.service.ts';

const {
Expand All @@ -8,8 +8,6 @@ const {
getStructureCheckByID,
getStructureCheckByProject,

createStructureCheck,
deleteStructureCheck,
} = useStructureCheck();

describe('structureCheck', (): void => {
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/views/courses/SearchCourseView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ onMounted(async () => {
<div class="grid">
<div class="col-12 xl:col-3">
<Accordion :active-index="[0]" multiple>
<AccordionTab header="Zoeken">
<AccordionTab :header="t('views.courses.search.search')">
<IconField iconPosition="left">
<InputText placeholder="Zoek een vak op naam" v-model="filter.search" class="w-full" />
<InputText :placeholder="t('views.courses.search.placeholder')" v-model="filter.search" class="w-full" />
<InputIcon class="pi pi-search"></InputIcon>
</IconField>
</AccordionTab>
<AccordionTab header="Faculteit" v-if="faculties">
<AccordionTab :header="t('views.courses.search.faculty')" v-if="faculties">
<div v-for="faculty in faculties" :key="faculty.id" class="flex align-items-center mb-2">
<Checkbox
v-model="filter.faculties"
Expand All @@ -80,7 +80,7 @@ onMounted(async () => {
<label :for="faculty.id" class="ml-2 text-sm">{{ faculty.name }}</label>
</div>
</AccordionTab>
<AccordionTab header="Academiejaar" v-if="user">
<AccordionTab :header="t('views.courses.search.year')" v-if="user">
<div v-for="year in user.academic_years" :key="year" class="flex align-items-center mb-2">
<Checkbox
v-model="filter.years"
Expand Down

0 comments on commit 314eaba

Please sign in to comment.