From 6b6061a73055b9f061431ecea44c971cf48dafce Mon Sep 17 00:00:00 2001
From: bsilkyn <brent.silkyn@ugent.be>
Date: Wed, 22 May 2024 18:33:54 +0200
Subject: [PATCH] test: course make and course enroll test with id's applied
 where necessary #434

---
 backend/authentication/views.py                      |  1 +
 frontend/src/components/courses/CourseDetailCard.vue |  2 +-
 frontend/src/components/courses/CourseDetailList.vue |  2 +-
 frontend/src/components/courses/CourseForm.vue       |  2 +-
 .../courses/students/StudentCourseJoinButton.vue     |  1 +
 frontend/src/components/projects/ProjectList.vue     |  2 +-
 .../views/dashboard/roles/TeacherDashboardView.vue   | 12 ++++++++----
 test.sh                                              |  7 ++++---
 8 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/backend/authentication/views.py b/backend/authentication/views.py
index ca985f31..f5745821 100644
--- a/backend/authentication/views.py
+++ b/backend/authentication/views.py
@@ -105,6 +105,7 @@ def login_professor(self, request, *__) -> Response:
         user, created = create_user(self, request, settings.TEST_PROFESSOR_DATA)
         if created:
             Teacher.create(user)
+        return response
 
     @action(detail=False, methods=['POST'], permission_classes=[IsDebug], url_path='multi')
     def login_multi(self, request, *__) -> Response:
diff --git a/frontend/src/components/courses/CourseDetailCard.vue b/frontend/src/components/courses/CourseDetailCard.vue
index 049ee0f3..ce92fc59 100644
--- a/frontend/src/components/courses/CourseDetailCard.vue
+++ b/frontend/src/components/courses/CourseDetailCard.vue
@@ -19,7 +19,7 @@ const { getImport } = useGlob(import.meta.glob('@/assets/img/faculties/*.png', {
 
 <template>
     <RouterLink :to="{ name: 'course', params: { courseId: course.id } }">
-        <Card class="border-round course-card max-w-30rem">
+        <Card id="course" class="border-round course-card max-w-30rem">
             <template #header>
                 <div class="flex align-items-center justify-content-center text-white relative p-3 text-center h-12rem">
                     <img
diff --git a/frontend/src/components/courses/CourseDetailList.vue b/frontend/src/components/courses/CourseDetailList.vue
index dddb4755..70a1a96b 100644
--- a/frontend/src/components/courses/CourseDetailList.vue
+++ b/frontend/src/components/courses/CourseDetailList.vue
@@ -46,7 +46,7 @@ const { t } = useI18n();
                     <span class="pi pi-exclamation-circle text-6xl text-primary" />
                     <slot name="empty">
                         <p>{{ t('components.list.noCourses.student') }}</p>
-                        <RouterLink :to="{ name: 'courses' }">
+                        <RouterLink id="courses" :to="{ name: 'courses' }">
                             <Button :label="t('components.button.searchCourse')" icon="pi pi-search" />
                         </RouterLink>
                     </slot>
diff --git a/frontend/src/components/courses/CourseForm.vue b/frontend/src/components/courses/CourseForm.vue
index 8cf979c1..38f60a9f 100644
--- a/frontend/src/components/courses/CourseForm.vue
+++ b/frontend/src/components/courses/CourseForm.vue
@@ -122,7 +122,7 @@ watchEffect(() => {
         </div>
 
         <!-- Submit button -->
-        <Button :label="t('views.courses.save')" type="submit" icon="pi pi-check" iconPos="right" rounded />
+        <Button id="courseSave" :label="t('views.courses.save')" type="submit" icon="pi pi-check" iconPos="right" rounded />
     </form>
 </template>
 
diff --git a/frontend/src/components/courses/students/StudentCourseJoinButton.vue b/frontend/src/components/courses/students/StudentCourseJoinButton.vue
index 34da3478..43a38921 100644
--- a/frontend/src/components/courses/students/StudentCourseJoinButton.vue
+++ b/frontend/src/components/courses/students/StudentCourseJoinButton.vue
@@ -66,6 +66,7 @@ async function leaveCourse(): Promise<void> {
 
 <template>
     <Button
+        id="courseEnroll"
         class="text-sm p-0"
         :label="t('views.courses.enroll')"
         icon-pos="right"
diff --git a/frontend/src/components/projects/ProjectList.vue b/frontend/src/components/projects/ProjectList.vue
index ab6be293..87bf871f 100644
--- a/frontend/src/components/projects/ProjectList.vue
+++ b/frontend/src/components/projects/ProjectList.vue
@@ -141,7 +141,7 @@ const incomingProjects = computed<Project[] | null>(() => {
                 <div class="mt-3">
                     <slot name="empty">
                         <p>{{ t('components.list.noProjects.student') }}</p>
-                        <RouterLink :to="{ name: 'courses' }">
+                        <RouterLink id="courses" :to="{ name: 'courses' }">
                             <Button :label="t('components.button.searchCourse')" icon="pi pi-search" />
                         </RouterLink>
                     </slot>
diff --git a/frontend/src/views/dashboard/roles/TeacherDashboardView.vue b/frontend/src/views/dashboard/roles/TeacherDashboardView.vue
index 6f0faf55..76bec7f8 100644
--- a/frontend/src/views/dashboard/roles/TeacherDashboardView.vue
+++ b/frontend/src/views/dashboard/roles/TeacherDashboardView.vue
@@ -59,7 +59,11 @@ watchImmediate(
                 <Title class="m-0">{{ t('views.dashboard.projects') }}</Title>
 
                 <!-- Create project button -->
-                <ProjectCreateButton :courses="filteredCourses" :label="t('components.button.createProject')" />
+                <ProjectCreateButton
+                    id="projectCreate"
+                    :courses="filteredCourses"
+                    :label="t('components.button.createProject')"
+                />
             </div>
             <!-- Project list body -->
             <ProjectList :projects="projects">
@@ -79,7 +83,7 @@ watchImmediate(
                             {{ t('components.list.noCourses.teacher') }}
                         </p>
 
-                        <ProjectCreateButton :courses="filteredCourses" :label="t('components.button.createProject')" />
+                        <ProjectCreateButton id="projectCreate" :courses="filteredCourses" :label="t('components.button.createProject')" />
                     </template>
                 </template>
             </ProjectList>
@@ -95,7 +99,7 @@ watchImmediate(
                     <YearSelector :years="allYears" v-model="selectedYear" />
 
                     <!-- Create course button -->
-                    <RouterLink :to="{ name: 'course-create' }">
+                    <RouterLink id="courseCreate" :to="{ name: 'course-create' }">
                         <Button
                             :icon="PrimeIcons.PLUS"
                             icon-pos="right"
@@ -109,7 +113,7 @@ watchImmediate(
             <CourseList :courses="filteredCourses">
                 <template #empty>
                     <p>{{ t('components.list.noCourses.teacher') }}</p>
-                    <RouterLink :to="{ name: 'course-create' }">
+                    <RouterLink id="courseCreate" :to="{ name: 'course-create' }">
                         <Button :label="t('components.button.createCourse')" icon="pi pi-plus" />
                     </RouterLink>
                 </template>
diff --git a/test.sh b/test.sh
index 6f665f2d..61b6c3a6 100755
--- a/test.sh
+++ b/test.sh
@@ -67,9 +67,10 @@ django_exit=0
 if [ "$frontend" = true ]; then
     echo "Running frontend tests..."
     echo "Filling up database with test data"
-    docker exec backend sh -c "python manage.py flush --no-input; python manage.py migrate; python manage.py loaddata
-      notifications/fixtures/$data/*; python manage.py loaddata authentication/fixtures/$data/*; python
-      manage.py loaddata api/fixtures/$data/*;"
+    docker exec backend sh -c "python manage.py flush --no-input; python manage.py migrate;
+      python manage.py loaddata notifications/fixtures/realistic/*;
+      python manage.py loaddata authentication/fixtures/realistic/*;
+      python manage.py loaddata api/fixtures/realistic/*;"
     echo "Running Cypress tests..."
     docker-compose -f test.yml up --exit-code-from cypress --abort-on-container-exit  cypress
     cypress_exit=$?