chore: linting

SELab-2 · Apr 2, 2024 · 9ca6088 · 9ca6088
1 parent f8c61cc
commit 9ca6088
Show file tree

Hide file tree

Showing 7 changed files with 49 additions and 61 deletions.
diff --git a/frontend/.eslintrc.cjs b/frontend/.eslintrc.cjs
@@ -1,45 +1,45 @@
 module.exports = {
-    "env": {
-        "browser": true,
-        "es2021": true
+    'env': {
+        'browser': true,
+        'es2021': true
     },
-    "extends": [
-        "standard-with-typescript",
-        "plugin:vue/vue3-essential",
-        "plugin:prettier/recommended"
+    'extends': [
+        'standard-with-typescript',
+        'plugin:vue/vue3-essential',
+        'plugin:prettier/recommended'
     ],
-    "overrides": [
+    'overrides': [
         {
-            "env": {
-                "node": true
+            'env': {
+                'node': true
             },
-            "files": [
-                ".eslintrc.{js,cjs}"
+            'files': [
+                '.eslintrc.{js,cjs}'
             ],
-            "parserOptions": {
-                "sourceType": "script",
-            },
+            'parserOptions': {
+                'sourceType': 'script'
+            }
         }
     ],
-    "parser": "vue-eslint-parser",
-    "parserOptions": {
-        "parser": "@typescript-eslint/parser" ,
-        "ecmaVersion": "latest",
-        "sourceType": "module",
-        "project": ["./tsconfig.json"],
-        "extraFileExtensions": [".vue"]
+    'parser': 'vue-eslint-parser',
+    'parserOptions': {
+        'parser': '@typescript-eslint/parser',
+        'ecmaVersion': 'latest',
+        'sourceType': 'module',
+        'project': ['./tsconfig.json'],
+        'extraFileExtensions': ['.vue']
     },
-    "plugins": [
-        "vue",
-        "prettier"
+    'plugins': [
+        'vue',
+        'prettier'
     ],
-    "rules": {
-        "vue/multi-word-component-names": "off",  // Disable rule that requires multi-word component names in Vue files
-        "@typescript-eslint/no-floating-promises": "off", // Disable rule that flags floating promises in .ts files
-        "@typescript-eslint/no-extraneous-class": "off", // Disable rule that flags usage of unnecessary classes in the codebase
-        "@typescript-eslint/unbound-method": "off", // Disable rule that refuses unbound methods that could scope `this`
-        "prettier/prettier": "error",
-        "function-paren-newline": "off",
-        "function-call-argument-newline": "off"
+    'rules': {
+        'vue/multi-word-component-names': 'off',  // Disable rule that requires multi-word component names in Vue files
+        '@typescript-eslint/no-floating-promises': 'off', // Disable rule that flags floating promises in .ts files
+        '@typescript-eslint/no-extraneous-class': 'off', // Disable rule that flags usage of unnecessary classes in the codebase
+        '@typescript-eslint/unbound-method': 'off', // Disable rule that refuses unbound methods that could scope `this`
+        'prettier/prettier': "error",
+        'function-paren-newline': 'off',
+        'function-call-argument-newline': 'off'
     }
-}
+};
diff --git a/frontend/.prettierrc b/frontend/.prettierrc
@@ -6,6 +6,7 @@
 	"singleQuote": true,
 	"arrowParens": "always",
 	"wrapParens": "avoid",
+	"endOfLine": "auto",
 	"jsxBracketSameLine": true,
 	"bracketSameLine": true
 }
diff --git a/frontend/src/components/YearSelector.vue b/frontend/src/components/YearSelector.vue
@@ -13,8 +13,8 @@ const props = defineProps<{ years: number[] }>();
 const years = computed(() =>
     props.years.map((year) => ({
         label: `${year} - ${year + 1}`,
-        value: year
-    }))
+        value: year,
+    })),
 );
 
 /* Models */

diff --git a/frontend/src/types/users/User.ts b/frontend/src/types/users/User.ts
@@ -42,7 +42,7 @@ export class User {
      * @param date
      * @returns number
      */
-    public getAcademicYear(date: Date = new Date): number {
+    public getAcademicYear(date: Date = new Date()): number {
         const year = date.getFullYear();
 
         if (date.getMonth() >= 9) {

diff --git a/frontend/src/views/courses/roles/StudentCourseView.vue b/frontend/src/views/courses/roles/StudentCourseView.vue
@@ -1,11 +1,7 @@
-<script setup lang="ts">
-
-</script>
+<script setup lang="ts"></script>
 
 <template>
-
+    <div/>
 </template>
 
-<style scoped lang="scss">
-
-</style>
+<style scoped lang="scss"></style>
diff --git a/frontend/src/views/courses/roles/TeacherCourseView.vue b/frontend/src/views/courses/roles/TeacherCourseView.vue
@@ -1,11 +1,8 @@
 <script setup lang="ts">
-
 </script>
 
 <template>
-
+    <div/>
 </template>
 
-<style scoped lang="scss">
-
-</style>
+<style scoped lang="scss"></style>
diff --git a/frontend/src/views/dashboard/roles/StudentDashboardView.vue b/frontend/src/views/dashboard/roles/StudentDashboardView.vue
@@ -3,9 +3,9 @@ import ButtonGroup from 'primevue/buttongroup';
 import Button from 'primevue/button';
 import Title from '@/components/layout/Title.vue';
 import YearSelector from '@/components/YearSelector.vue';
-import CourseList from '@/components/courses/CourseList.vue'
+import CourseList from '@/components/courses/CourseList.vue';
 import ProjectList from '@/components/projects/ProjectList.vue';
-import { Student } from '@/types/users/Student.ts';
+import { type Student } from '@/types/users/Student.ts';
 import { PrimeIcons } from 'primevue/api';
 import { useI18n } from 'vue-i18n';
 import { computed, ref, watch } from 'vue';
@@ -23,11 +23,7 @@ const { courses, getCoursesByStudent } = useCourses();
 /* State */
 const selectedYear = ref<number>(props.student.getAcademicYear());
 
-const filteredCourses = computed(() =>
-    courses.value?.filter((course) =>
-        course.academic_startyear === selectedYear.value
-    ) ?? []
-);
+const filteredCourses = computed(() => courses.value?.filter((course) => course.academic_startyear === selectedYear.value) ?? []);
 
 /* Watchers */
 watch(
@@ -37,7 +33,7 @@ watch(
     },
     {
         immediate: true,
-    }
+    },
 );
 </script>
 
@@ -50,7 +46,7 @@ watch(
         <ButtonGroup class="flex align-items-center">
             <YearSelector :years="student.academic_years" v-model="selectedYear" />
             <RouterLink :to="{ name: 'courses' }">
-                <Button :icon="PrimeIcons.PLUS" icon-pos="right" class="custom-button" style="height:51px; width: 51px;" />
+                <Button :icon="PrimeIcons.PLUS" icon-pos="right" class="custom-button" style="height: 51px; width: 51px" />
             </RouterLink>
         </ButtonGroup>
     </div>
@@ -69,6 +65,4 @@ watch(
     <ProjectList :courses="filteredCourses" />
 </template>
 
-<style scoped lang="scss">
-
-</style>
+<style scoped lang="scss"></style>