Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend cleanup #223

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Frontend cleanup #223

merged 6 commits into from
Apr 3, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented Apr 2, 2024 •
edited
Loading

  • Improved the authentication store by extending the user store with all possible roles
  • Removed courses from the User model since admins don't have courses
  • Extracted the dashboard logic into more components for code clarity
  • Added role-specific views, e.g. StudentDashboardView vs. AssistantDashboardView vs. TeacherDashboardView. Goal is to seperate the role-specific views for cleaner and less confusing code
  • Finished some lay-out details
  • Modified and added important ESLint rules

@EwoutV EwoutV added feature A new feature containing functionality frontend Issues regarding the frontend labels Apr 2, 2024
@EwoutV EwoutV added this to the Frontend milestone milestone Apr 2, 2024
@EwoutV EwoutV requested a review from BramMeir April 2, 2024 22:15
@EwoutV EwoutV self-assigned this Apr 2, 2024
BramMeir
BramMeir approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@BramMeir BramMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BramMeir BramMeir merged commit 856e744 into development Apr 3, 2024
3 checks passed
@BramMeir BramMeir deleted the frontend-cleanup branch April 3, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BramMeir BramMeir BramMeir approved these changes

Assignees

@EwoutV EwoutV

Labels
feature A new feature containing functionality frontend Issues regarding the frontend
Projects
None yet
Milestone
Frontend milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EwoutV @BramMeir