Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course search #231

Merged
merged 15 commits into from
Apr 4, 2024
Merged

Course search #231

merged 15 commits into from
Apr 4, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented Apr 4, 2024

  • Added course search (every role)
  • Added filtering and pagination composables
  • Added possibility for students to join and leave courses
  • Improved the authentication data flow for better reactivity
  • Improved the faculty model with translated names and icons
  • Improved async/await constructs

closes #226

@EwoutV EwoutV added this to the Frontend milestone milestone Apr 4, 2024
@EwoutV EwoutV self-assigned this Apr 4, 2024
francisvaut
francisvaut requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@francisvaut francisvaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall.
I didn't run either test.sh or development.sh because both scripts failed upon execution.

backend/api/views/course_view.py Outdated Show resolved Hide resolved
backend/authentication/models.py Outdated Show resolved Hide resolved
backend/authentication/views.py Outdated Show resolved Hide resolved
frontend/src/test/unit/setup.ts Outdated Show resolved Hide resolved
frontend/.prettierrc Outdated Show resolved Hide resolved
frontend/src/views/courses/SearchCourseView.vue Outdated Show resolved Hide resolved
@EwoutV EwoutV requested a review from francisvaut April 4, 2024 16:55
BramMeir
BramMeir approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@BramMeir BramMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@francisvaut francisvaut merged commit 99a8858 into development Apr 4, 2024
3 checks passed
@EwoutV EwoutV mentioned this pull request Apr 5, 2024
Closed
@EwoutV EwoutV deleted the course-search branch April 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BramMeir BramMeir BramMeir approved these changes

@francisvaut francisvaut francisvaut approved these changes

Assignees

@EwoutV EwoutV

Labels
None yet
Projects
None yet
Milestone
Frontend milestone
Development

Successfully merging this pull request may close these issues.

Frontend: course list
3 participants
@EwoutV @BramMeir @francisvaut