Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better academic year selector, filtering and sorting #292

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Better academic year selector, filtering and sorting #292

merged 2 commits into from
Apr 11, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented Apr 11, 2024

  • The academic year selector is now based on provided arguments as opposed to the user's account creation year
  • Improved the sorting and filtering composables to be more consistent and dynamic
  • Added a new paginator for courses, including the minimum and maximum academic years

closes #264
closes #262

@EwoutV EwoutV added feature A new feature containing functionality frontend Issues regarding the frontend backend(api) labels Apr 11, 2024
@EwoutV EwoutV added this to the Frontend milestone milestone Apr 11, 2024
@EwoutV EwoutV self-assigned this Apr 11, 2024
Topvennie
Topvennie approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@EwoutV EwoutV merged commit 0a6e5e5 into development Apr 11, 2024
3 checks passed
@EwoutV EwoutV deleted the year-picker branch April 11, 2024 20:27
francisvaut pushed a commit that referenced this pull request Apr 12, 2024
@EwoutV @francisvaut
Better academic year selector, filtering and sorting (#292)
55eb4a2 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
EwoutV added a commit that referenced this pull request Apr 12, 2024
@francisvaut @EwoutV
@Topvennie @BramMeir
Services fix, tests (#297)
415911d 
* test: create course

* fix: send id to backend when creating faculty

* test: create faculty

* test: create group

* test: cleanup create tests

* test: assistant type

* test: services and types folder

* test: start with create project

* test: cleanup setup file

* test: cleanup request handlers

* test: reset services + fix mistakes in teacher/assistant service

* chore: fix linting

* test: create project

* chore: linting autofix

* chore: bring back multipart/from-data

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* fix: re-add translations

* chore: display faculty in course edit

* fix: courses to create projects filtered on selected calendar date

* fix: make teacher command

* fix: linting

* test: admin delete

* test: fix service mistake, assistant delete

---------

Co-authored-by: Ewout Verlinde <ewoutverlinde@hotmail.com>
Co-authored-by: Vincent Vallaeys <vincent@vallaeys.com>
Co-authored-by: Bram Meir <bram.meir@ugent.be>
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
4e56ef9 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@francisvaut @EwoutV
@Topvennie @BramMeir @DeLany123
Services fix, tests (#297)
ab63516 
* test: create course

* fix: send id to backend when creating faculty

* test: create faculty

* test: create group

* test: cleanup create tests

* test: assistant type

* test: services and types folder

* test: start with create project

* test: cleanup setup file

* test: cleanup request handlers

* test: reset services + fix mistakes in teacher/assistant service

* chore: fix linting

* test: create project

* chore: linting autofix

* chore: bring back multipart/from-data

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* fix: re-add translations

* chore: display faculty in course edit

* fix: courses to create projects filtered on selected calendar date

* fix: make teacher command

* fix: linting

* test: admin delete

* test: fix service mistake, assistant delete

---------

Co-authored-by: Ewout Verlinde <ewoutverlinde@hotmail.com>
Co-authored-by: Vincent Vallaeys <vincent@vallaeys.com>
Co-authored-by: Bram Meir <bram.meir@ugent.be>
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
4386c67 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
0d57993 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
a74963c 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
1c752ac 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
d3e1569 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
0d8c2bf 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
cb69b28 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
EwoutV added a commit that referenced this pull request Apr 18, 2024
@DeLany123 @EwoutV @Topvennie
Submission view (#333)
56c21f7 
* feat: allsubmissions view

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* feat: allsubmissions view 2

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* Frontend rebased submission view

* chore: commit before merge

* chore: commit before rebasing

* fix: Frontend works on new submissions

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* Frontend rebased submission view

* chore: commit before merge

* chore: finish logic submissionView.vue

* chore: bugfixes and layout

* chore: Finished submissionView

* chore: lint fixes for #333

* chore: Removed useless checks #333

* chore: impossible to fail now #333

* chore: impossible to fail now v2 #333

* chore: changes to make Ewout happy

---------

Co-authored-by: Ewout Verlinde <ewoutverlinde@hotmail.com>
Co-authored-by: Vincent Vallaeys <vincent@vallaeys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Topvennie Topvennie Topvennie approved these changes

@tyboro2002 tyboro2002 Awaiting requested review from tyboro2002

@BramMeir BramMeir Awaiting requested review from BramMeir

@francisvaut francisvaut Awaiting requested review from francisvaut

Assignees

@EwoutV EwoutV

Labels
feature A new feature containing functionality frontend Issues regarding the frontend
Projects
None yet
Milestone
Frontend milestone
Development

Successfully merging this pull request may close these issues.

frontend: academic year picker frontend: projects only shown when deadline is not passed on dashboard
2 participants
@EwoutV @Topvennie