feat: Admin Panel Route Guard #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsilkyn
requested review from
Topvennie,
EwoutV,
DeLany123,
tyboro2002,
BramMeir and
francisvaut
|
Wait with merging until demo is done |
|
It can be merged now, after being reviewed |
tyboro2002
requested changes
Apr 19, 2024
| @@ -12,6 +12,7 @@ import VerifyView from '@/views/authentication/VerifyView.vue'; | |||
| import { type RouteRecordRaw, createWebHistory, createRouter } from 'vue-router'; | |||
| import { AuthenticationGuard } from '@/router/guards/authentication.guard.ts'; | |||
| import { LogoutGuard } from '@/router/guards/logout.guard.ts'; | |||
| import { AdminGuard } from '@/router/guards/admin.guard.ts'; | |||
There was a problem hiding this comment.
from where is this file this is not in the repo
you can also set the pr to a normal pr instead of a draft to notify this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A route guard for the admin panel would be quite handy to prevent non-admins from reaching it in the first place