Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course link refactor #403

Merged
merged 12 commits into from
May 5, 2024
Merged

Course link refactor #403

merged 12 commits into from
May 5, 2024

Conversation

BramMeir
Copy link
Contributor

@BramMeir BramMeir commented May 4, 2024

closes #401

Refactor the links to join a course. Now a real link can be shared, redirecting to an information page about the course with the possibility to join that course.

@BramMeir BramMeir added frontend Issues regarding the frontend backend labels May 4, 2024
@BramMeir BramMeir added this to the Final milestone milestone May 4, 2024
@BramMeir BramMeir self-assigned this May 4, 2024
Copy link
Contributor

@tyboro2002 tyboro2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -137,7 +137,7 @@
"placeholder": "Find a course using the registration link"
},
"share": {
"title": "Create invitation link",
"title": "Activate invitation link",
"duration": "Validity period link (in days):",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would go for "Validity period of link (in days):"

@BramMeir BramMeir merged commit a9efaa7 into development May 5, 2024
3 checks passed
@BramMeir BramMeir deleted the course-link-refactor branch May 5, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend frontend Issues regarding the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: refactor course links
2 participants