Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra checks frontend #417

Merged
merged 13 commits into from
May 13, 2024
Merged

Extra checks frontend #417

merged 13 commits into from
May 13, 2024

Conversation

BramMeir
Copy link
Contributor

closes #398

Extra checks frontend functionality:

  • Option to add multiple extra checks when creating a project.
  • Option to add/remove extra checks when updating a project.

Some little backend fixes

@BramMeir BramMeir added the frontend Issues regarding the frontend label May 11, 2024
@BramMeir BramMeir added this to the Final milestone milestone May 11, 2024
@BramMeir BramMeir self-assigned this May 11, 2024
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@DeLany123
Copy link
Contributor

DeLany123 commented May 13, 2024

Super clean dialog field.
Some small comments:

  • "Making logfile visible to students", I think it would be a little better to give more context to the logfile here, like "Making the extra logs of the docker container visible to the students" for example.

image
I think the different layout of the extra checks stands a bit to much out.

@DeLany123 DeLany123 merged commit def84ab into development May 13, 2024
3 checks passed
@DeLany123 DeLany123 deleted the extra-checks-frontend branch May 13, 2024 11:07
@DeLany123 DeLany123 restored the extra-checks-frontend branch May 13, 2024 11:07
@bsilkyn bsilkyn deleted the extra-checks-frontend branch May 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues regarding the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: upload sh script as teacher
3 participants