chore: better submission status #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the failing tests: both frontend and backend tests succeed, Cypress fails. |
tyboro2002
requested changes
May 16, 2024
| return [ | ||
| { | ||
| value: (submissionsPassed / groups) * 100, | ||
| value: (extraChecksPassed / groups) * 100, |
There was a problem hiding this comment.
Isn't it possible to have extrachecks passed but structure checks not? I would change this to the min of those 2.
There was a problem hiding this comment.
That code is not extrachecks and structurechecks for a single submission, but for a whole project (PojectMeter).
There was a problem hiding this comment.
You should round this to the nearest integer to account for representation errors, it could happen that the meter now displays 22.3333333333331%.
There was a problem hiding this comment.
Actually, the MeterGroup component already rounds these values by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #418
structure_checksandextra_checksin backend instead of theis_validfield.