Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra checks #455

Merged
merged 12 commits into from
May 23, 2024
Merged

Fix extra checks #455

merged 12 commits into from
May 23, 2024

Conversation

BramMeir
Copy link
Contributor

  • Option to show the generated artifacts to the students
  • Option to remove private docker images
  • Fix new students join individual projects automatically
  • Remove emojis after democratic decision

@BramMeir BramMeir added the frontend Issues regarding the frontend label May 23, 2024
@BramMeir BramMeir added this to the Final milestone milestone May 23, 2024
@BramMeir BramMeir requested review from Topvennie and EwoutV May 23, 2024 13:18
@BramMeir BramMeir self-assigned this May 23, 2024
Copy link
Contributor

@francisvaut francisvaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I don't know what exactly goes wrong but when creating a project with multiple extra checks and different combinations for artifacts and logs visibilty, I get the following error:

ValueError: Field 'id' expected a number but got ''.
"POST /api/projects/4/extra_checks/ HTTP/1.0" 500 19216
 Internal Server Error: /api/projects/4/extra_checks/

backend/api/serializers/course_serializer.py Show resolved Hide resolved
frontend/src/assets/lang/app/nl.json Show resolved Hide resolved
frontend/src/composables/services/course.service.ts Outdated Show resolved Hide resolved
@BramMeir
Copy link
Contributor Author

Looks good overall, but I don't know what exactly goes wrong but when creating a project with multiple extra checks and different combinations for artifacts and logs visibilty, I get the following error:

ValueError: Field 'id' expected a number but got ''.
"POST /api/projects/4/extra_checks/ HTTP/1.0" 500 19216
 Internal Server Error: /api/projects/4/extra_checks/

I see the issue, when you create multiple extra checks the form is reset. But by doing this, the docker image field is set to a default empty one. So when you don't select a docker image in the list, this passes the validation but will not work when making the request. I will fix that.

Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

Copy link
Contributor

@francisvaut francisvaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌

@francisvaut francisvaut merged commit cd9935c into development May 23, 2024
3 checks passed
@bsilkyn bsilkyn deleted the fix-extra-checks branch May 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues regarding the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants