-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Github url parse error for some scenarios #3683
Conversation
cumulusci/utils/git.py
Outdated
@@ -81,6 +82,6 @@ def parse_repo_url(url: str) -> Tuple[str, str, str]: | |||
|
|||
host = url_parts[-3] | |||
# Need to consider "https://api.github.com/repos/owner/repo/" pattern | |||
if "http" in url_parts[0] and len(url_parts) > 6: | |||
if "http" in url_parts[0] and len(url_parts) > 4 and not host.endswith(".com"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgrandhi This may work if hostname ends with .com, but if the user having hostname ends with different name then this may fail. Can we use regex instead of hard coding the value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fix Github parse issue during some scenarios as mentioned below