fix: DAH-2783 fix listing online details link (#2350)

* DAH-2783 force external link * DAH-2783 add code comments * DAH-2783 update to a tag * DAH-2783 update snapshot tests --------- Co-authored-by: cade-exygy <131277283+cade-exygy@users.noreply.github.com>
SFDigitalServices · Oct 10, 2024 · 141e4ff · 141e4ff
1 parent 420997f
commit 141e4ff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...ipt/__tests__/modules/listingDetails/__snapshots__/ListingDetailsSeeTheUnit.test.tsx.snap b/...ipt/__tests__/modules/listingDetails/__snapshots__/ListingDetailsSeeTheUnit.test.tsx.snap
@@ -228,8 +228,8 @@ exports[`ListingDetailsSeeTheUnit renders SeeDetailsOnline when both MLS and Lis
           </div>
           <div>
             <a
-              class="seeds-link no-underline"
               href="https://www.google.com/"
+              target="_blank"
             >
               Online Detail
             </a>
@@ -444,8 +444,8 @@ exports[`ListingDetailsSeeTheUnit renders SeeDetailsOnline when only Listing_Onl
         >
           <div>
             <a
-              class="seeds-link no-underline"
               href="https://www.google.com/"
+              target="_blank"
             >
               Online Detail
             </a>

diff --git a/app/javascript/modules/listingDetailsAside/ListingDetailsSeeTheUnit.tsx b/app/javascript/modules/listingDetailsAside/ListingDetailsSeeTheUnit.tsx
@@ -49,9 +49,9 @@ const SeeDetailsOnline = (listing: RailsListing) => (
         const link = detail.URL.includes("http") ? detail.URL : `//${detail.URL}`
         return (
           <div key={detail.Id}>
-            <Link className="no-underline" href={link} hideExternalLinkIcon={true}>
+            <a href={link} target="_blank">
               {detail.Listing_Online_Detail_Name}
-            </Link>
+            </a>
           </div>
         )
       })}