remove redundant window.setFlags() and pass window_settings to presen…

…ter by value
SFTtech · Dec 7, 2024 · 8094dc6 · 8094dc6
1 parent 87da14e
commit 8094dc6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/libopenage/presenter/presenter.cpp b/libopenage/presenter/presenter.cpp
@@ -47,7 +47,7 @@ Presenter::Presenter(const util::Path &root_dir,
 	time_loop{time_loop} {}
 
 
-void Presenter::run(const renderer::window_settings &window_settings) {
+void Presenter::run(const renderer::window_settings window_settings) {
 	log::log(INFO << "Presenter: Launching subsystems...");
 
 	this->init_graphics(window_settings);

diff --git a/libopenage/presenter/presenter.h b/libopenage/presenter/presenter.h
@@ -91,7 +91,7 @@ class Presenter {
 	 *
 	 * @param window_settings The settings to customize the display window (e.g. size, display mode, vsync).
 	 */
-	void run(const renderer::window_settings &window_settings = {});
+	void run(const renderer::window_settings window_settings = {});
 
 	/**
 	 * Set the game simulation controlled by this presenter.

diff --git a/libopenage/renderer/opengl/window.cpp b/libopenage/renderer/opengl/window.cpp
@@ -62,7 +62,7 @@ GlWindow::GlWindow(const std::string &title,
 	this->window->setWindowState(Qt::WindowNoState);
 	switch (settings.mode) {
 	case window_mode::WINDOWED:
-		this->window->setFlags(this->window->flags() & ~Qt::FramelessWindowHint);
+		// nothing to do because it's the default
 		break;
 	case window_mode::BORDERLESS:
 		this->window->setFlags(this->window->flags() | Qt::FramelessWindowHint);