Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the project overview #10

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Abhishek022001
Copy link
Contributor

@Abhishek022001 Abhishek022001 commented Nov 9, 2024

PR name: Improved the project overview

PR description: #1

Short summary

This pull request is to improve the Project overview section

Name: Detailed project Overview

Description: Fixes #1

Made a detailed project overview section in the READ.ME FILE

Issue Number- #1

Short Summary

Better readability of Project overview section, and added more details

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
music-recommendation-using-facial-expressions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 5:38pm

@SGCODEX
Copy link
Owner

SGCODEX commented Nov 10, 2024

Great work @Abhishek022001, The project overview looks way better.
Please just edit your PR according to the PR Template we are following: https://github.com/SGCODEX/Music-Recommendation-Using-Facial-Expressions/blob/main/CONTRIBUTING.md#pr-template

@Abhishek022001
Copy link
Contributor Author

Please check now if its okay

@SGCODEX
Copy link
Owner

SGCODEX commented Nov 12, 2024

Heyy, I think there is a little bit confusion.
I meant like this:

Title: Improved the project overview
Fixes #1
Improved project overview section in the READ.ME FILE

Copy link
Owner

@SGCODEX SGCODEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this looks good, Thank you for contributing. Looking forward towards more.

@SGCODEX SGCODEX merged commit a320184 into SGCODEX:main Nov 12, 2024
2 checks passed
@SGCODEX
Copy link
Owner

SGCODEX commented Nov 12, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Project Overview part in Readme File
2 participants