Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsat core results #125

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Fix unsat core results #125

merged 4 commits into from
Jul 30, 2024

Conversation

martinjonas
Copy link
Contributor

The validation of UNSAT core results was not implemented according to the rules. According to the rules

The unsatisfiability of an unsat core is refuted if the number of validation solvers whose result is sat exceeds the number of checking solvers whose result is unsat.

whereas we considered the returned core validated if and only if at least one solver returned result unsat. As a result, the unsat cores where all the validation solvers timed out were incorrectly refuted.

@martinjonas martinjonas merged commit b433fcb into master Jul 30, 2024
2 checks passed
@martinjonas martinjonas deleted the fix_unsat_core_results branch July 30, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant