Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024process cloud #130

Merged
merged 6 commits into from
Sep 12, 2024
Merged

2024process cloud #130

merged 6 commits into from
Sep 12, 2024

Conversation

mbromber
Copy link
Contributor

No description provided.

@mbromber mbromber requested a review from bobot September 11, 2024 09:10
Copy link
Contributor

@bobot bobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some info in the readme? It is similar to the other one so just the specific part should be enough.

selection = smtcomp.selection.helper(config, track).filter(selected=True).with_columns(track=int(track))

selection = selection.unique()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you precise why you found duplicate rows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment explaining it to the file.

- if a file mapping.json is present it used and the original_id.csv is not needed
- if original_id is present it is used (all the other track)
- if it ends with "unsatcore" and the directory "../unsat_core_valisation_results" is present and converted (feather file) it is used to validate the unsat cores
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is not valid for this function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the doc.

smtcomp/results.py Outdated Show resolved Hide resolved
mbromber and others added 2 commits September 11, 2024 14:17
Co-authored-by: François Bobot <francois.bobot@cea.fr>
@mbromber
Copy link
Contributor Author

Can you add some info in the readme? It is similar to the other one so just the specific part should be enough.

Done.

@mbromber mbromber merged commit a71d958 into master Sep 12, 2024
2 checks passed
@mbromber mbromber deleted the 2024processCloud branch September 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants