Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mori axion 2023 #285

Merged
merged 23 commits into from
Nov 29, 2023
Merged

Mori axion 2023 #285

merged 23 commits into from
Nov 29, 2023

Conversation

sybenzvi
Copy link
Contributor

Add models with axionlike particle production, using the 2D simulations from Mori+ 2023. Estimates of the PNS mass are included in the paper. The commit adds the Mori_2023 models to the snewpy registry, includes unit tests, and functions with the mori-axion-models-2023 branch of snewpy-models-ccsn.

@sybenzvi sybenzvi added the enhancement New feature or request label Oct 14, 2023
Copy link
Contributor

@Sheshuk Sheshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work implementing these models!

As I commented in the text, I have two small suggestions:

  1. make the input parameters Quantities
  2. move filling the metadata (in particular PNS mass) to the ccsn.Mori_2023 from loaders.Mori_2023

python/snewpy/models/ccsn.py Outdated Show resolved Hide resolved
python/snewpy/models/ccsn.py Outdated Show resolved Hide resolved
python/snewpy/models/ccsn.py Outdated Show resolved Hide resolved
python/snewpy/models/loaders.py Outdated Show resolved Hide resolved
@sybenzvi
Copy link
Contributor Author

Thanks for the review @Sheshuk, I implemented all your requested changes and I think this model is good to go.

Copy link
Contributor

@Sheshuk Sheshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! Now everything looks good to me

@Sheshuk Sheshuk merged commit fddf516 into main Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants