-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mori axion 2023 #285
Mori axion 2023 #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work implementing these models!
As I commented in the text, I have two small suggestions:
- make the input parameters Quantities
- move filling the metadata (in particular PNS mass) to the
ccsn.Mori_2023
fromloaders.Mori_2023
Co-authored-by: Andrey Sheshukov <dxdydz2@gmail.com>
Co-authored-by: Andrey Sheshukov <dxdydz2@gmail.com>
Co-authored-by: Andrey Sheshukov <dxdydz2@gmail.com>
Thanks for the review @Sheshuk, I implemented all your requested changes and I think this model is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! Now everything looks good to me
Add models with axionlike particle production, using the 2D simulations from Mori+ 2023. Estimates of the PNS mass are included in the paper. The commit adds the
Mori_2023
models to thesnewpy
registry, includes unit tests, and functions with the mori-axion-models-2023 branch ofsnewpy-models-ccsn
.