EOS deprecations #360
Merged
EOS deprecations #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there’s only a single option for either, those shouldn’t be initialisation parameters. The model has not yet appeared in a public release, so this doesn’t require a deprecation.
…e value Was already marked as deprecated in the GarchingArchiveModel docstring, but let’s make it more explicit here.
sybenzvi
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #356 I noticed that there were a few more SN model classes that had only a single option for the
eosargument but where it wasn’t marked as@deprecated. This PR adds deprecation markers to those models; in line with the docstring of theGarchingArchiveModelclass (which these four models all inherit from).For the
Fischer_2020model, which was just added in #347, I’m also moving theeosargument to a metadata field. (No deprecation necessary here, because this was never in a published release.)