Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File "private/soci-trivial-blob-backend.h" missing #1153

Closed
Spixmaster opened this issue Jun 7, 2024 · 5 comments
Closed

File "private/soci-trivial-blob-backend.h" missing #1153

Spixmaster opened this issue Jun 7, 2024 · 5 comments

Comments

@Spixmaster
Copy link
Contributor

@Krzmbrzl, the commit #992 includes #include <private/soci-trivial-blob-backend.h> which is not present when installed with CMake.
@Krzmbrzl
Copy link
Contributor

Krzmbrzl commented Jun 7, 2024

See my revamp cmake PR. I think there this should be fixed

@Spixmaster
Copy link
Contributor Author

#1118 for reference.

@Spixmaster Spixmaster mentioned this issue Jun 7, 2024
Open
@vadz
Copy link
Member

vadz commented Jun 8, 2024

Private headers are not supposed to be installed, so if this header is used by the public headers, it can't be private.

I.e. it's not (just) a build system problem, it's a problem with the header name/path.

@Spixmaster
Copy link
Contributor Author

Spixmaster commented Jun 8, 2024 •
edited
Loading

The header is used two times, here and here.

Krzmbrzl added a commit to Krzmbrzl/soci that referenced this issue Aug 31, 2024
@Krzmbrzl
Move trivial blob backend to public includes
55da03c 
Since private headers are (and also should not be) installed, this
makes it impossible to compile SOCI as an installed package.

Fixes SOCI#1153
Krzmbrzl added a commit to Krzmbrzl/soci that referenced this issue Aug 31, 2024
@Krzmbrzl
Move trivial blob backend to public includes
489556b 
Since private headers are (and also should not be) installed, this
makes it impossible to compile SOCI as an installed package.

Fixes SOCI#1153
@Krzmbrzl Krzmbrzl mentioned this issue Aug 31, 2024
Closed
@Krzmbrzl
Copy link
Contributor

I had another look at this and am now in line with what @vadz said. That is, I misused private headers. Consequently, this is fixed in #1165

@vadz vadz closed this as completed in 943a780 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move trivial blob backend to public includes Krzmbrzl/soci
3 participants
@vadz @Krzmbrzl @Spixmaster