Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate last Android Tests to Unit Tests #477

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Migrate last Android Tests to Unit Tests #477

wants to merge 4 commits into from

Conversation

MGaetan89
Copy link
Member

Pull request

Description

This PR migrates the last Android Tests (in IsPlayingAllTypeOfContentTest) to regular Unit Tests.

Note

In draft for now, because there is one case that is failing.

Changes made

  • Migrate IsPlayingAllTypeOfContentTest to use Robolectric as a regular Unit Test
  • Disable Android Tests on the CI
  • The Dependency Analysis step now displays the warnings, instead of uploading a zip file

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 19, 2024
@MGaetan89 MGaetan89 added this to the Test milestone Mar 19, 2024
@MGaetan89 MGaetan89 self-assigned this Mar 19, 2024
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 4 times, most recently from f68a894 to 5c77be2 Compare April 8, 2024 09:41
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 4 times, most recently from c679f09 to 4fff6bd Compare April 24, 2024 17:52
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 3 times, most recently from 8081789 to baee7cc Compare May 10, 2024 09:53
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 34cbc1b to 83a10f1 Compare June 19, 2024 14:53
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from f58eb65 to 535d6d9 Compare July 2, 2024 07:40
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 3 times, most recently from 8a7d830 to 24ba495 Compare July 18, 2024 06:44
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 0cc820c to 7d87a1a Compare July 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MGaetan89 MGaetan89

Labels
enhancement New feature or request
Projects
Pillarbox
Status: 📋 Backlog
Milestone
Test
Development

Successfully merging this pull request may close these issues.
1 participant
@MGaetan89