Move HalfStepHook inheritance to python #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloferz
force-pushed
the
pz/overhaul
branch
from
d9f0e52
to
2ed2e99
Compare
pabloferz
force-pushed
the
pz/overhaul
branch
4 times, most recently
from
72c3ce3
to
baa6082
Compare
pabloferz
force-pushed
the
pz/overhaul
branch
2 times, most recently
from
8b8f003
to
87a5d05
Compare
So setuptools-scm is able to detect the version.
pabloferz
force-pushed
the
pz/overhaul
branch
from
87a5d05
to
d06ab59
Compare
4 tasks
trunk-io bot
pushed a commit
to SSAGESLabs/PySAGES
that referenced
this pull request
Sep 19, 2023
This PR addresses the following small but unrelated issues: - [x] Missed edge cases not handled by #280 (71b5fa4). - [x] Some recent combination of changes on either or both CuPy and Jax makes `cupy.asarray(x)` for `x: JaxArray` return a copy instead of a view (134d085). - [x] Upcoming compatibility changes introduced by SSAGESLabs/hoomd-dlext/pull/23 (71991b5). - [x] Some fonts were intended to be loaded by #281, but currently fail (e6533cd).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we define a
Sampleron the C++ side which hasforward_datato handle the scope ofhoomd::ArrayHandle. I have renamed our C++SamplertoCallbackHandlerand have moved the definition ofSamplerto the Python side. Hopefully we would sort out issues we were observing when building the conda-forge package.The PR also adds versioning to the
hoomd.dlextmodule, which we were missing.