-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update master #1087
Open
dlyr
wants to merge
196
commits into
master
Choose a base branch
from
release-candidate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update master #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[external] Fix pass Qt version to external build.
[cmake] request version 3.18
Co-authored-by: Mathias Paulin <MathiasPaulin@users.noreply.github.com>
…ons-for-windowsvisual-studio 1051 clarify build instructions for windowsvisual studio
fix msvc warning
Small fixes
and move to VariableSet.
allow plain enum and underlying_type (with *EnumVariable method) management.
Move to namespace functions.
remove friend, move add widget public, add accessor for private data allow recursive visit for contained variable set
Co-authored-by: Mathias Paulin <MathiasPaulin@users.noreply.github.com>
Simply ignore output order, but could be better integrating recursion.
make RenderParameters inherit from VariableSet and remove duplicated code.
[ci] Manual doc build uses deploy-doc, remove doc build from pr ci.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR SHOULD NOT BE MERGED (must be done by hand)
Long time we haven't merge RC on master