Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uyuni BV: Add workaround for Deblike minions #1000

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Oct 20, 2023

This will

  • add a workaround for Debian 10 and Ubuntu 20.04
  • remove the Debian 9 comment

@nodeg nodeg self-assigned this Oct 20, 2023
@nodeg nodeg requested a review from Bischoff October 20, 2023 11:18
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see remarks

@@ -881,8 +895,6 @@ module "ubuntu2204-sshminion" {
ssh_key_path = "./salt/controller/id_rsa.pub"
}

// Debian 9 is not supported by 4.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... or you change it to:

// Debian 9 is not supported by Uyuni

@@ -479,8 +483,6 @@ module "ubuntu2204-minion" {
ssh_key_path = "./salt/controller/id_rsa.pub"
}

// Debian 9 is not supported by 4.3
Copy link
Contributor

@Bischoff Bischoff Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... or you change it to:

// Debian 9 is not supported by Uyuni

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@nodeg nodeg requested a review from Bischoff October 20, 2023 11:44
@nodeg nodeg merged commit fd2e275 into SUSE:master Oct 20, 2023
1 check passed
@nodeg nodeg deleted the uyuny-bv branch October 20, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants