Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paygo aws pipeline #1021

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Paygo aws pipeline #1021

merged 10 commits into from
Dec 14, 2023

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Nov 15, 2023

@maximenoel8 maximenoel8 self-assigned this Nov 15, 2023
@maximenoel8 maximenoel8 marked this pull request as draft November 15, 2023 20:37
@maximenoel8 maximenoel8 requested a review from a team December 13, 2023 09:40
@maximenoel8 maximenoel8 marked this pull request as ready for review December 13, 2023 09:41
Copy link
Member

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, looks good

Comment on lines +468 to +476
sle12sp5_client_configuration = module.sles12sp5-client.configuration
sle12sp5_minion_configuration = module.sles12sp5-minion.configuration
sle12sp5_sshminion_configuration = module.sles12sp5-sshminion.configuration

sle15sp4_client_configuration = module.sles15sp4-client.configuration
sle15sp4_minion_configuration = module.sles15sp4-minion.configuration
sle15sp4_sshminion_configuration = module.sles15sp4-sshminion.configuration

sle15sp5_minion_configuration = module.sles15sp5-minion.configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the no-paygo minions anywhere for this PAYGO AWS Pipeline?
Would it make sense to test something not PAYG related on this pipeline?

Copy link
Contributor Author

@maximenoel8 maximenoel8 Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't cost much to add those minions and give us some feedback on paygo server. During my manual testing, I found some issues testing 'classic' minions with the paygo server. Just checking if the repositories are available is not enough in my opinion. Maybe we could limit it to minion. But it's really free to add those extra minions . I don't have server instability on AWS ( also with limited minions ).

@maximenoel8 maximenoel8 merged commit d47068f into SUSE:master Dec 14, 2023
1 check failed
@maximenoel8 maximenoel8 deleted the paygo-aws-pipeline branch December 14, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants