Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing product_version to s390 Minions #1296

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Aug 14, 2024

Fixes

  • renderning error:
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): local:
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     Data failed to compile:
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): ----------
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     Rendering SLS 'base:repos' failed: Jinja error: argument of type 'NoneType' is not iterable
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): Traceback (most recent call last):
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "/usr/lib/python3.6/site-packages/salt/utils/templates.py", line 476, in render_jinja_tmpl
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     output = template.render(**decoded_context)
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "/usr/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     return original_render(self, *args, **kwargs)
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "/usr/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     return self.environment.handle_exception(exc_info, True)
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "/usr/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     reraise(exc_type, exc_value, tb)
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "/usr/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):     raise value.with_traceback(tb)
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   File "<template>", line 18, in top-level template code
[2024-08-14T10:15:53.058Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): TypeError: argument of type 'NoneType' is not iterable
[2024-08-14T10:15:53.987Z]
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): ; line 18
[2024-08-14T10:15:53.987Z]
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): ---
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): [...]
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.testsuite
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.tools
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.jenkins
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.server_containerized
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.proxy_containerized
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   {% if '4.3' not in grains.get('product_version') %}    <======================
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.ruby
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   {% endif %}
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   {% endif %}
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec):   - repos.additional
[2024-08-14T10:15:53.987Z]
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): [...]
[2024-08-14T10:15:53.987Z] module.sles15sp5s390-minion.null_resource.provisioning (remote-exec): ---
  • Leap 15.6 ARM image name
  • Missing Leap Micro in base config

currently this is not an issue, but it will be, once I merge uyuni-project/sumaform#1248. Since we always add a product_version to all Minions, this will align the s390 ones.

@nodeg nodeg self-assigned this Aug 14, 2024
@nodeg nodeg requested review from Bischoff and a team August 14, 2024 10:53
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodeg nodeg force-pushed the s390-product-version branch 2 times, most recently from ced7452 to c9bff9e Compare August 14, 2024 11:17
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@nodeg
Copy link
Member Author

nodeg commented Aug 14, 2024

Rebased the PR again.

@nodeg nodeg merged commit 03f5d1f into SUSE:master Aug 14, 2024
1 check passed
@nodeg nodeg deleted the s390-product-version branch August 14, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants