Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module to match testsuite minion tags. #1301

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Aug 15, 2024

Context

To be able to use directly the minionList to remove the disable minions from the deployment, rename the module names to match the testsuite tag.

Issue

https://github.com/SUSE/spacewalk/issues/25063

@maximenoel8 maximenoel8 self-assigned this Aug 15, 2024
@maximenoel8 maximenoel8 requested a review from a team August 15, 2024 23:20
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Maxime.

@nodeg
Copy link
Member

nodeg commented Aug 16, 2024

Once everything works as expected, please also change the other .tf tiles for the Uyuni/5.0 BV for both NUE and PRV. Thank you.

@maximenoel8 maximenoel8 merged commit b16da5a into SUSE:master Aug 18, 2024
1 check passed
@maximenoel8 maximenoel8 deleted the rename_module_PRV_43 branch August 18, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants