Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head branch is now 5.1 #1336

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Head branch is now 5.1 #1336

merged 1 commit into from
Sep 2, 2024

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Sep 2, 2024

This PR allows the change from 5.0 to 5.1 on Head branch.

It also removes temporary hacks

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I would double check with releng. I am also wondering why the URL is

registry.suse.de/devel/galaxy/manager/head/containerfile/suse/manager/5.1/x86_64

and not

registry.suse.de/devel/galaxy/manager/head/containerfile

since the mgr* tools will automatically apply the correct end path.

@Bischoff
Copy link
Contributor Author

Bischoff commented Sep 2, 2024

LGTM. However, I would double check with releng. I am also wondering why the URL is (...)

I was hoping you would know 😄 . My best guess was that mgrpxy and mgradm were incompatible in this respect.

I asked Marina.

@nodeg
Copy link
Member

nodeg commented Sep 2, 2024

In Uyuni Podman, we omit the end:

container_repository = "registry.opensuse.org/systemsmanagement/uyuni/master/containers_leap_15.6"

@deneb-alpha
Copy link
Contributor

for Head, what I know is that on Head we had before

%_default_namespace registry.suse.de/devel/galaxy/manager/head/containerfile/suse/manager/5.0
%_default_helm_registry registry.suse.de/devel/galaxy/manager/head/charts/suse/manager/5.0

and I bumped the value to 5.1 AKA

%_default_namespace registry.suse.de/devel/galaxy/manager/head/containerfile/suse/manager/5.1
%_default_helm_registry registry.suse.de/devel/galaxy/manager/head/charts/suse/manager/5.1

For 5.0 project, work is still in progress. I'm working at the IBS project now

@Bischoff
Copy link
Contributor Author

Bischoff commented Sep 2, 2024

In Uyuni Podman, we omit the end:

container_repository = "registry.opensuse.org/systemsmanagement/uyuni/master/containers_leap_15.6"

ok, then let's align everything.

@Bischoff Bischoff requested a review from nodeg September 2, 2024 14:35
@Bischoff Bischoff force-pushed the head-is-51 branch 2 times, most recently from cfd1ea4 to 62f6856 Compare September 2, 2024 15:04
@Bischoff Bischoff merged commit d028e9d into SUSE:master Sep 2, 2024
1 check passed
@Bischoff Bischoff deleted the head-is-51 branch September 5, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants