Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unuse parameters for uyuni and 5.0 BV pipelines #1425

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Oct 10, 2024

What does this PR ?

Remove all parameters not use during deployment. Either it's not used during the salt states ( example server_configuration without auto connect to master ) or default value is true ( venv-salt-bundle install ).

The idea is to simplify our BV description and later create a common template.

Depends on: uyuni-project/sumaform#1736.
I didn't impact 4.3 for stability.

@maximenoel8 maximenoel8 self-assigned this Oct 10, 2024
@maximenoel8 maximenoel8 requested a review from a team October 10, 2024 00:38
@srbarrios
Copy link
Member

Actually... we might want to keep server_configuration in build_host, depending of what we decide about autoconnect feature.
Ongoing discussion here uyuni-project/sumaform#1736

@Bischoff Bischoff self-requested a review October 10, 2024 12:22
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve what we do with uyuni-project/sumaform#1736 first

@maximenoel8
Copy link
Contributor Author

maximenoel8 commented Oct 10, 2024

Actually... we might want to keep server_configuration in build_host, depending of what we decide about autoconnect feature. Ongoing discussion here uyuni-project/sumaform#1736

Removing server_configuration from build_host is not related to build host changes but to auto_connect_to_master = false setup same than minion.

@srbarrios
Copy link
Member

Actually... we might want to keep server_configuration in build_host, depending of what we decide about autoconnect feature. Ongoing discussion here uyuni-project/sumaform#1736

Removing server_configuration from build_host is not related to build host changes but to auto_connect_to_master = false setup same than minion.

Indeed, if we keep it on false in these envs, we dont't need to provide any server config 👍

@maximenoel8 maximenoel8 dismissed Bischoff’s stale review October 13, 2024 20:00

Problem resolve in #1736

@maximenoel8 maximenoel8 merged commit 70b6275 into SUSE:master Oct 13, 2024
1 check passed
@maximenoel8 maximenoel8 deleted the remove_use_parameters_uyuni_50 branch October 13, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants