Remove auto connection to host variable from build host #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsamis
approved these changes
Oct 10, 2024
srbarrios
approved these changes
Oct 10, 2024
NamelessOne91
approved these changes
Oct 10, 2024
|
Let's first finish the discussion in uyuni-project/sumaform#1736 so we take a decision about autoconnect feature in build_host. |
Bischoff
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Let's resolve what we do with uyuni-project/sumaform#1736 first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR ?
In prevision of this sumaform PR: uyuni-project/sumaform#1736 remove the
auto_connect_to_mastervariable from build host to avoid error.Impact before PR =>
auto_connect_to_masterwill be set to true by default but it will change nothing during salt. stateAfter PR => variable
auto_connect_to_masterdoesn't exist anymore for build_host.