Make container repository configurable #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on 4.3 sle maintenance update pipeline and 5.0 BV NUE pipeline. |
Bischoff
approved these changes
Oct 16, 2024
szachovy
approved these changes
Oct 16, 2024
srbarrios
approved these changes
Oct 16, 2024
ktsamis
requested changes
Oct 16, 2024
|
Hi @ktsamis, if you look at jenkins_pipelines/environments/uyuni-master-qe-build-validation-NUE changes, you will see the url has been moved to the Jenkins description. Do you want it as default value in main.tf ? |
ktsamis
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when we have a new container image, we need to modify main.tf.
Create a variable for it and make it accessible at Jenkins level.
Related to: https://github.com/SUSE/spacewalk/issues/25212