Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int64_zigzag/2, uint32_codes, etc fail/error in a confusing way #8

Open
kamahen opened this issue Jul 9, 2021 · 2 comments
Open

int64_zigzag/2, uint32_codes, etc fail/error in a confusing way #8

kamahen opened this issue Jul 9, 2021 · 2 comments

Comments

@kamahen
Copy link
Member

kamahen commented Jul 9, 2021

This applies to all the predicates defined in protobufs.c

If an argument is instantiated and not of the appropriate type (integer, list(integer), etc., sometimes the predicate quietly fails, sometimes gives an incorrect "instantiation error", sometimes gives an appropriate error.

Implementation notes:
See PL_term_type() and return values PL_VARIABLE, PL_INTEGER.

Need to verify all instantiation errors and also add checks before some unification calls.

@kamahen
Copy link
Member Author

kamahen commented Jul 9, 2021

float32_codes/2 and float64_codes/4 should be modified to be similar to the other XXX_codes/2 predicates.

@kamahen
Copy link
Member Author

kamahen commented Jul 11, 2021

This is mostly fixed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant